-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: require trait function calls (Foo::bar()
) to have the trait in scope (imported)
#6882
Open
asterite
wants to merge
7
commits into
master
Choose a base branch
from
ab/require-trait-to-be-in-scope
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+423
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peak Memory Sample
|
Compilation Sample
|
Execution Sample
|
asterite
changed the title
feat: require trait methods to be in scope
feat: require trait function calls (Dec 19, 2024
Foo::bar()
) to be in scope
asterite
changed the title
feat: require trait function calls (
feat: require trait function calls (Dec 19, 2024
Foo::bar()
) to be in scopeFoo::bar()
) to have the trait in scope (imported)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Part of #6864
Summary
This PR is only about calls (
Foo::bar()
).There are many more cases to handle (methods, but also calls on primitive types like
Field::foo()
and method calls on primitive types) but it might be better to do all of this across many PRs so they are easier to review.Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.