Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: require trait primitive functions/calls to have their trait in scope #6900

Conversation

asterite
Copy link
Collaborator

Description

Based on top of #6895

Problem

Part of #6864

Summary

Similar to the previous PRs but this time for primitive types.

Additional Context

I think what's missing now is to do the same for "generic" types, for example if there's a trait impl for every (T), calling a method of that trait on a tuple might not currently require the trait to be in scope. But I'll do this in a follow-up PR.

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite merged commit dc6e95f into ab/require-trait-to-be-in-scope-for-methods Dec 20, 2024
25 checks passed
@asterite asterite deleted the ab/trait-functions-in-scope-for-primitives branch December 20, 2024 21:12
Copy link
Contributor

Peak Memory Sample

Program Peak Memory
keccak256 78.51M
workspace 123.88M
regression_4709 422.94M
ram_blowup_regression 1.58G
private-kernel-tail 168.30M
private-kernel-reset 168.33M
private-kernel-inner 168.30M
parity-root 151.61M

Copy link
Contributor

Compilation Sample

Program Compilation Time %
sha256_regression 1.344s -1%
regression_4709 0.779s -3%
ram_blowup_regression 15.281s -1%
noir-contracts 14.902s -6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant