.

noir-lang · TomAFrench · Jan 17, 2025 · Jan 14, 2025 · Jan 15, 2025 · Jan 15, 2025
commit 69cc9463133e546a7f0f30c0132ea173adb8f821
diff --git a/.github/workflows/reports.yml b/.github/workflows/reports.yml
@@ -735,6 +735,10 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
+      # deployments permission to deploy GitHub pages website
+      deployments: write
+      # contents permission to update benchmark contents in gh-pages branch
+      contents: write
 
     steps:
       - uses: actions/checkout@v4
@@ -773,7 +777,7 @@ jobs:
 
       - name: Convert to `benchmark-action` format
         run: |
-          jq ".execution_report | map({name: .artifact_name, value: (.time[:-1] | tonumber), unit: \"s\"}) " ./execution_report.json > time_bench.json
+          jq ".execution_reports | map({name: .artifact_name, value: (.time[:-1] | tonumber), unit: \"s\"}) " ./execution_report.json > time_bench.json
 
       - name: Store benchmark result
         # We always push new benchmarks so we want this to only run on master to avoid garbage data.``

diff --git a/compiler/noirc_evaluator/src/ssa/ir/instruction.rs b/compiler/noirc_evaluator/src/ssa/ir/instruction.rs
            MakeArray { .. } | Noop => false,

            // Some binary math can overflow or underflow
            Binary(binary) => match binary.operator {
                BinaryOp::Add { unchecked: false }
                | BinaryOp::Sub { unchecked: false }
                | BinaryOp::Mul { unchecked: false }
diff --git a/compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs b/compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs
    ///   br loop_entry(v0)
    /// loop_entry(i: Field):
    ///   v2 = lt i v1
    ///   brif v2, then: loop_body, else: loop_end
    /// loop_body():
    ///   v3 = ... codegen body ...
    ///   v4 = add 1, i
    ///
    /// ```text
    ///   v0 = ... codegen cond ...
    ///   brif v0, then: then_block, else: else_block
    /// then_block():
    ///   v1 = ... codegen a ...
    ///   br end_if(v1)
    ///
    /// ```text
    ///   v0 = ... codegen cond ...
    ///   brif v0, then: then_block, else: end_if
    /// then_block:
    ///   v1 = ... codegen a ...
    ///   br end_if()
	MakeArray { .. } \| Noop => false,

	// Some binary math can overflow or underflow
	Binary(binary) => match binary.operator {
Check warning on line 414 in compiler/noirc_evaluator/src/ssa/ir/instruction.rs GitHub Actions / Code `Unknown word (effectful)`
	BinaryOp::Add { unchecked: false }
	\| BinaryOp::Sub { unchecked: false }
	\| BinaryOp::Mul { unchecked: false }
	/// br loop_entry(v0)
	/// loop_entry(i: Field):
	/// v2 = lt i v1
	/// brif v2, then: loop_body, else: loop_end
Check warning on line 525 in compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs GitHub Actions / Code `Unknown word (brif)`
	/// loop_body():
	/// v3 = ... codegen body ...
	/// v4 = add 1, i
	///
	/// ```text
	/// v0 = ... codegen cond ...
	/// brif v0, then: then_block, else: else_block
Check warning on line 596 in compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs GitHub Actions / Code `Unknown word (brif)`
	/// then_block():
	/// v1 = ... codegen a ...
	/// br end_if(v1)
	///
	/// ```text
	/// v0 = ... codegen cond ...
	/// brif v0, then: then_block, else: end_if
Check warning on line 611 in compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs GitHub Actions / Code `Unknown word (brif)`
	/// then_block:
	/// v1 = ... codegen a ...
	/// br end_if()