Skip to content

Commit

Permalink
Merge pull request crossplane#6117 from phisco/ignore-other-xpkgs
Browse files Browse the repository at this point in the history
tests: ignore also image-configs manifests from renovate
  • Loading branch information
phisco authored Nov 15, 2024
2 parents 02a6e89 + f24ed44 commit 38f3bf6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
'design/**',
// We test upgrades, so leave it on an older version on purpose.
"test/e2e/manifests/pkg/provider/provider-initial.yaml",
// Manifests must remain unchanged to ensure the test scenario is not broken.
// We test dependencies' upgrades, manifests must remain unchanged to avoid breaking tests.
"test/e2e/manifests/pkg/dependency-upgrade/**",
// We test packages signature verifications also on upgrades, manifests must remain unchanged to avoid breaking tests.
"test/e2e/manifests/pkg/image-config/signature-verification/**"
],
postUpdateOptions: [
'gomodTidy',
Expand Down
15 changes: 15 additions & 0 deletions test/e2e/pkg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,11 @@ func TestNoDowngrade(t *testing.T) {
)
}

// TestImageConfigAuth tests that we can install a private package as a dependency by providing registry pull
// credentials through ImageConfig API.
// The packages used in this test are built and pushed manually and the manifests must remain unchanged to ensure
// the test scenario is not broken. Corresponding meta file can be found at
// test/e2e/manifests/pkg/image-config/authentication/configuration-with-private-dependency/package.
func TestImageConfigAuth(t *testing.T) {
manifests := "test/e2e/manifests/pkg/image-config/authentication/configuration-with-private-dependency"

Expand Down Expand Up @@ -562,6 +567,9 @@ func TestImageConfigAuth(t *testing.T) {
)
}

// TestImageConfigVerificationWithKey tests that we can verify signature on a configuration when signed with a key.
// The providers used in this test are built and pushed manually with the necessary signatures and attestations, they
// are just a copy of the provider-nop package.
func TestImageConfigVerificationWithKey(t *testing.T) {
manifests := "test/e2e/manifests/pkg/image-config/signature-verification/with-key"

Expand Down Expand Up @@ -595,6 +603,9 @@ func TestImageConfigVerificationWithKey(t *testing.T) {
)
}

// TestImageConfigVerificationKeyless tests that we can verify signature on a provider when signed keyless.
// The providers used in this test are built and pushed manually with the necessary signatures and attestations, they
// are just a copy of the provider-nop package.
func TestImageConfigVerificationKeyless(t *testing.T) {
manifests := "test/e2e/manifests/pkg/image-config/signature-verification/keyless"

Expand Down Expand Up @@ -632,6 +643,10 @@ func TestImageConfigVerificationKeyless(t *testing.T) {
)
}

// TestImageConfigAttestationVerificationPrivateKeyless tests that we can verify signature and attestations on a private
// provider when signed keyless.
// The providers used in this test are built and pushed manually with the necessary signatures and attestations, they
// are just a copy of the provider-nop package.
func TestImageConfigAttestationVerificationPrivateKeyless(t *testing.T) {
manifests := "test/e2e/manifests/pkg/image-config/signature-verification/keyless-private-with-attestation"

Expand Down

0 comments on commit 38f3bf6

Please sign in to comment.