Skip to content

Commit

Permalink
Replace binding.GNOIClients with gnoigo.Clients (openconfig#2291)
Browse files Browse the repository at this point in the history
  • Loading branch information
greg-dennis authored Oct 24, 2023
1 parent 5aa57be commit 520bae4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ import (
"github.com/openconfig/featureprofiles/internal/fptest"
"github.com/openconfig/featureprofiles/internal/gribi"
"github.com/openconfig/featureprofiles/internal/otgutils"
"github.com/openconfig/gnoigo"
"github.com/openconfig/gnoigo/system"
"github.com/openconfig/gribigo/chk"
"github.com/openconfig/gribigo/constants"
"github.com/openconfig/gribigo/fluent"
"github.com/openconfig/ondatra"
"github.com/openconfig/ondatra/binding"
"github.com/openconfig/ondatra/gnmi"
"github.com/openconfig/ondatra/gnmi/oc"
"github.com/openconfig/ondatra/gnoi"
Expand Down Expand Up @@ -126,7 +126,7 @@ var ipBlock1FlowArgs = &flowArgs{
}

// coreFileCheck function is used to check if cores are found on the DUT.
func coreFileCheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient binding.GNOIClients, sysConfigTime uint64, retry bool) {
func coreFileCheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient gnoigo.Clients, sysConfigTime uint64, retry bool) {
t.Helper()
t.Log("Checking for core files on DUT")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ import (
"github.com/openconfig/featureprofiles/internal/fptest"
"github.com/openconfig/featureprofiles/internal/gribi"
"github.com/openconfig/featureprofiles/internal/otgutils"
"github.com/openconfig/gnoigo"
"github.com/openconfig/gnoigo/system"
gpb "github.com/openconfig/gribi/v1/proto/service"
"github.com/openconfig/gribigo/chk"
"github.com/openconfig/gribigo/constants"
"github.com/openconfig/gribigo/fluent"
"github.com/openconfig/ondatra"
"github.com/openconfig/ondatra/binding"
"github.com/openconfig/ondatra/gnmi"
"github.com/openconfig/ondatra/gnmi/oc"
"github.com/openconfig/ondatra/gnoi"
Expand Down Expand Up @@ -105,7 +105,7 @@ var (
)

// coreFileCheck function is used to check if any cores found during test execution.
func coreFilecheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient binding.GNOIClients, sysConfigTime uint64) {
func coreFilecheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient gnoigo.Clients, sysConfigTime uint64) {
// vendorCoreFilePath and vendorCoreProcName should be provided to fetch core file on dut.
if _, ok := vendorCoreFilePath[dut.Vendor()]; !ok {
t.Fatalf("Please add support for vendor %v in var vendorCoreFilePath ", dut.Vendor())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import (
"github.com/openconfig/featureprofiles/internal/components"
"github.com/openconfig/featureprofiles/internal/deviations"
"github.com/openconfig/featureprofiles/internal/fptest"
"github.com/openconfig/gnoigo"
"github.com/openconfig/ondatra"
"github.com/openconfig/ondatra/binding"
"github.com/openconfig/ondatra/gnmi"
"github.com/openconfig/ondatra/gnmi/oc"
"github.com/openconfig/ygnmi/ygnmi"
Expand Down Expand Up @@ -63,7 +63,7 @@ const (
)

// coreFileCheck function is used to check if cores are found on the DUT.
func coreFileCheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient binding.GNOIClients, sysConfigTime uint64, retry bool) {
func coreFileCheck(t *testing.T, dut *ondatra.DUTDevice, gnoiClient gnoigo.Clients, sysConfigTime uint64, retry bool) {
t.Helper()
t.Log("Checking for core files on DUT")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import (
"github.com/openconfig/featureprofiles/internal/deviations"
"github.com/openconfig/featureprofiles/internal/fptest"
plqpb "github.com/openconfig/gnoi/packet_link_qualification"
"github.com/openconfig/gnoigo"
"github.com/openconfig/ondatra"
"github.com/openconfig/ondatra/binding"
"github.com/openconfig/ondatra/gnmi"
"github.com/openconfig/ondatra/gnmi/oc"
"github.com/openconfig/ygot/ygot"
Expand Down Expand Up @@ -159,7 +159,7 @@ func TestListDelete(t *testing.T) {
gnoiClient1 := dut1.RawAPIs().GNOI(t)
gnoiClient2 := dut2.RawAPIs().GNOI(t)

clients := []binding.GNOIClients{gnoiClient1, gnoiClient2}
clients := []gnoigo.Clients{gnoiClient1, gnoiClient2}
for i, client := range clients {
t.Logf("Check client: %d", i+1)
listResp, err := client.LinkQualification().List(context.Background(), &plqpb.ListRequest{})
Expand Down Expand Up @@ -337,7 +337,7 @@ func TestLinkQualification(t *testing.T) {
t.Logf("Wait for %v seconds: %d/%d", sleepTime.Seconds(), i+1, counter)
time.Sleep(sleepTime)
testDone := true
for i, client := range []binding.GNOIClients{gnoiClient1, gnoiClient2} {
for i, client := range []gnoigo.Clients{gnoiClient1, gnoiClient2} {
t.Logf("Check client: %d", i+1)

listResp, err := client.LinkQualification().List(context.Background(), &plqpb.ListRequest{})
Expand Down Expand Up @@ -367,7 +367,7 @@ func TestLinkQualification(t *testing.T) {

var generatorPktsSent, generatorPktsRxed, reflectorPktsSent, reflectorPktsRxed uint64

for i, client := range []binding.GNOIClients{gnoiClient1, gnoiClient2} {
for i, client := range []gnoigo.Clients{gnoiClient1, gnoiClient2} {
t.Logf("Check client: %d", i+1)
getResp, err := client.LinkQualification().Get(context.Background(), getRequest)
t.Logf("LinkQualification().Get(): %v, err: %v", getResp, err)
Expand Down

0 comments on commit 520bae4

Please sign in to comment.