Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 #29

Merged
merged 181 commits into from
Oct 27, 2023
Merged

Release 1.1.0 #29

merged 181 commits into from
Oct 27, 2023

Conversation

raczu
Copy link
Member

@raczu raczu commented Oct 10, 2023

Motivation

The main objective of this release is to improve the logic for handling and sending requests to NCM API, as well as simplifying the use of ncm-issuer for users. Therefore, a few features/improvements have been implemented.

Changes

  1. Prometheus metrics have been added, in order to be able to check how many CSR objects have been processed by the ncm-issuer. A breakdown into the given labels was used here: unrecognised, enrollment, renewal. The enrollment and renewal can be used for filtering to see how many CSR objects with a given label have been correctly processed (certificate_request_successes_total). The same applies to checking how many of them have an error (certificate_request_fails_total), but here you can also use label unrecognised. In the case of errors, there is also an additional label which determines whether ncm-issuer will try to process again given CSR. Additionally, it is possible to check processing time per CSR: certificate_request_time_seconds.
  2. To improve debugging in the case of any errors, a sidecar has been added, as well as the possibility of specifying logging verbosity level, for more information see: Troubleshooting section in README.
  3. The NCM API selection mechanism has been improved - it is now implemented using a first-alive algorithm.
  4. Improved the logic for sending the CSR to the NCM API and verifying whether a certificate has already been issued by NCM. This has reduced the number of unnecessary request to NCM API - CSR objects for which certificates have not yet been issued are queued and processed after a defined period of time.
  5. In order to apply the above features/improvements, a change in the definition of ClusterIssuer and Issuer have been made. The fields in their definition have been grouped into appropriate sections, and some of the old fields have received new, more user-friendly names - the old fields are still supported, but will be removed within a few releases. The new definition of ClusterIssuer and Issuer is described in Custom resource definitions (CRDs) section of README.
  6. Helm charts were changed to implement prometheus metrics and sidecar. Additionally, charts were refactored according to the best practices given by Helm.

LissaGreense and others added 30 commits March 3, 2023 13:43
* Update unit_test.yml

* Update README.md
Added go report and terminal video
To include image loaded to public repo + change of default replica to 1 only.
Just some small updates here and there ...
To include some things that came up after late-evening breaking of stuff by Grindsa ;-)
Fixed bug "cannot find package "."" that occurred after changing the module name
raczu added 5 commits October 12, 2023 19:51
Previous way of pulling image somehow failed
for specific releases of k8s. The change was
made to fix it and instead of using local
registry image is now loading via microk8s.
@raczu raczu added scope: docs Indicates that PR relates to documentation changes. scope: code Indicates that issue or PR relates to code. type: feature PR's categorised as feature. type: cleanup/refactor PR's categorised as cleanup or refactor. scope: helm Indicates that issue or PR relates to Helm. labels Oct 13, 2023
@raczu raczu requested a review from misiektoja October 13, 2023 16:40
@raczu raczu requested a review from BbqGamer October 27, 2023 21:12
Copy link
Collaborator

@BbqGamer BbqGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

56.9% 56.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@raczu raczu merged commit dc03ada into main Oct 27, 2023
119 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code Indicates that issue or PR relates to code. scope: docs Indicates that PR relates to documentation changes. scope: helm Indicates that issue or PR relates to Helm. type: cleanup/refactor PR's categorised as cleanup or refactor. type: feature PR's categorised as feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants