-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.1.0 #29
Merged
Merged
Release 1.1.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update unit_test.yml * Update README.md
Added go report and terminal video
To include image loaded to public repo + change of default replica to 1 only.
Just some small updates here and there ...
To include some things that came up after late-evening breaking of stuff by Grindsa ;-)
Fixed bug "cannot find package "."" that occurred after changing the module name
Small typos corrected.
Previous way of pulling image somehow failed for specific releases of k8s. The change was made to fix it and instead of using local registry image is now loading via microk8s.
raczu
added
scope: docs
Indicates that PR relates to documentation changes.
scope: code
Indicates that issue or PR relates to code.
type: feature
PR's categorised as feature.
type: cleanup/refactor
PR's categorised as cleanup or refactor.
scope: helm
Indicates that issue or PR relates to Helm.
labels
Oct 13, 2023
Previous prometheus metrics was focused to monitor CR resource, however, they were supposed to monitor enrollment and renewal operations of certificates that was sent to NCM API. Thus, the new implementation was introduced to attempt to reflect the number of CSRs and renewals operations sent to NCM and count how many of them were processed succesfully or somehow failed.
Add github release actions - mkdocs and helm on gh-pages
BbqGamer
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarCloud Quality Gate failed. 0 Bugs 56.9% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: code
Indicates that issue or PR relates to code.
scope: docs
Indicates that PR relates to documentation changes.
scope: helm
Indicates that issue or PR relates to Helm.
type: cleanup/refactor
PR's categorised as cleanup or refactor.
type: feature
PR's categorised as feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main objective of this release is to improve the logic for handling and sending requests to NCM API, as well as simplifying the use of ncm-issuer for users. Therefore, a few features/improvements have been implemented.
Changes
unrecognised
,enrollment
,renewal
. Theenrollment
andrenewal
can be used for filtering to see how many CSR objects with a given label have been correctly processed (certificate_request_successes_total
). The same applies to checking how many of them have an error (certificate_request_fails_total
), but here you can also use labelunrecognised
. In the case of errors, there is also an additional label which determines whether ncm-issuer will try to process again given CSR. Additionally, it is possible to check processing time per CSR:certificate_request_time_seconds
.ClusterIssuer
andIssuer
have been made. The fields in their definition have been grouped into appropriate sections, and some of the old fields have received new, more user-friendly names - the old fields are still supported, but will be removed within a few releases. The new definition ofClusterIssuer
andIssuer
is described in Custom resource definitions (CRDs) section of README.