Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, remove deprecated actions from workflows #37

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix, remove deprecated actions from workflows #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78d0e5f
Fix, remove deprecated actions from workflows
Jul 25, 2024
cee094a
Remove 3rd party deprecated action, use bash sleep insted
Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions .github/workflows/caname-id-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -51,9 +51,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -90,9 +88,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -166,7 +162,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-cahref.tar.gz
Expand All @@ -193,7 +189,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -211,9 +207,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -247,9 +241,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -323,7 +315,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-caname.tar.gz
Expand Down
16 changes: 5 additions & 11 deletions .github/workflows/clientauth-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -56,9 +56,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -103,9 +101,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -164,9 +160,7 @@ jobs:
sudo -E cmctl renew ncm-cert -n ncm-issuer

- name: "sleep for 15s"
uses: juliangruber/sleep-action@v1
with:
time: 15s
run: sleep 15

- name: "check certificate resource"
run: |
Expand Down Expand Up @@ -198,7 +192,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-k${{ matrix.k8s-version }}-${{ matrix.certmgr-version }}.tar.gz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
docker save ncm-issuer > ncm-issuer-image.tar
echo "ncm-issuer image built and saved to ncm-issuer-image.tar"
- name: "Upload ncm-issuer image"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ncm-issuer-image
path: ncm-issuer-image.tar
Expand Down
32 changes: 10 additions & 22 deletions .github/workflows/pkey-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -54,9 +54,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -99,9 +97,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -162,9 +158,7 @@ jobs:
sudo -E cmctl renew ncm-cert -n ncm-issuer

- name: "sleep for 15s"
uses: juliangruber/sleep-action@v1
with:
time: 15s
run: sleep 15

- name: "check certificate resource"
run: |
Expand Down Expand Up @@ -196,7 +190,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-ecdsa${{ matrix.keysize }}.tar.gz
Expand Down Expand Up @@ -226,7 +220,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -244,9 +238,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -288,9 +280,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -351,9 +341,7 @@ jobs:
sudo -E cmctl renew ncm-cert -n ncm-issuer

- name: "sleep for 15s"
uses: juliangruber/sleep-action@v1
with:
time: 15s
run: sleep 15

- name: "check certificate resource"
run: |
Expand Down Expand Up @@ -385,7 +373,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-ecdsa${{ matrix.keysize }}.tar.gz
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/san-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -67,9 +67,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -107,9 +105,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -188,7 +184,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-ecdsa${{ matrix.keysize }}.tar.gz
Expand Down
30 changes: 10 additions & 20 deletions .github/workflows/signer-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand Down Expand Up @@ -92,10 +92,8 @@ jobs:
run: |
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
- name: "sleep for 15s"
run: sleep 15

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -153,9 +151,7 @@ jobs:
sudo -E cmctl renew ncm-cert -n ncm-issuer

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "check certificate resource"
run: |
Expand Down Expand Up @@ -187,7 +183,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artificates"
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-k${{ matrix.k8sversion }}-${{ matrix.certmgr-version }}.tar.gz
Expand Down Expand Up @@ -219,7 +215,7 @@ jobs:
run: echo "KUBECONFIG=/var/snap/microk8s/current/credentials/client.config" >> $GITHUB_ENV

- name: "Download ncm-issuer image"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ inputs.image-artifact-name }}
path: .
Expand All @@ -237,9 +233,7 @@ jobs:
- run: echo "cert-manager ${{ env.CERTMGR_VERSION }}"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "cert-manager status"
run: |
Expand Down Expand Up @@ -287,9 +281,7 @@ jobs:
sudo microk8s.helm3 install -n ncm-issuer ncm-issuer "$(pwd)/helm"

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "ncm-issuer plugin status"
run: |
Expand Down Expand Up @@ -349,9 +341,7 @@ jobs:
sudo -E cmctl renew ncm-cert -n ncm-cert

- name: "sleep for 10s"
uses: juliangruber/sleep-action@v1
with:
time: 10s
run: sleep 10

- name: "check certificate resource"
run: |
Expand Down Expand Up @@ -385,7 +375,7 @@ jobs:
sudo tar -C ${{ github.workspace }}/artifact/ -cvzf ${{ github.workspace }}/artifact/upload/artifact.tar.gz data

- name: "[ * ] uploading artifacts"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: logs-k${{ matrix.k8sversion }}-${{ matrix.certmgr-version }}.tar.gz
Expand Down