Fix invalid parser error in range-based loops

nokia · Oct 25, 2024 · 461ef7a · 461ef7a
1 parent 1f34a6d
commit 461ef7a
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 69 deletions.
diff --git a/ttcn3/printer/printer.go b/ttcn3/printer/printer.go
@@ -306,8 +306,7 @@ func (p *printer) print(values ...interface{}) {
 			}
 			p.print(n.Tok)
 			p.print(n.LParen)
-			p.print(n.VarTok)
-			p.print(n.Var)
+			p.print(n.Init)
 			p.print(n.InTok)
 			p.print(n.Range)
 			p.print(n.RParen)

diff --git a/ttcn3/scopes.go b/ttcn3/scopes.go
@@ -138,9 +138,7 @@ func NewScope(n syntax.Node, tree *Tree) *Scope {
 		scp.add(n.Init)
 
 	case *syntax.ForRangeStmt:
-		if (n.VarTok != nil) && (n.Var != nil) {
-			scp.Insert(n.Var, n.Var)
-		}
+		scp.add(n.Init)
 
 	case *syntax.IfStmt:
 		scp.add(n.Then)

diff --git a/ttcn3/syntax/nodes.go b/ttcn3/syntax/nodes.go
@@ -424,9 +424,7 @@ type (
 	ForRangeStmt struct {
 		Tok    Token
 		LParen Token
-		VarTok Token
-		Type   TypeSpec
-		Var    *Ident
+		Init   Stmt
 		InTok  Token
 		Range  Expr
 		RParen Token

diff --git a/ttcn3/syntax/nodes_gen.go b/ttcn3/syntax/nodes_gen.go
diff --git a/ttcn3/syntax/parser.go b/ttcn3/syntax/parser.go
@@ -2469,9 +2469,6 @@ func (p *parser) parseStmt() Stmt {
 	case LBRACK:
 		return p.parseAltGuard()
 	case FOR:
-		if p.peek(4).Kind() == IN || p.peek(5).Kind() == IN || p.peek(6).Kind() == IN {
-			return p.parseForRangeLoop()
-		}
 		return p.parseForLoop()
 	case WHILE:
 		return p.parseWhileLoop()
@@ -2522,15 +2519,36 @@ func (p *parser) parseStmt() Stmt {
 	}
 }
 
-func (p *parser) parseForLoop() *ForStmt {
-	x := new(ForStmt)
-	x.Tok = p.consume()
-	x.LParen = p.expect(LPAREN)
+func (p *parser) parseForLoop() Stmt {
+	forTok := p.consume()
+	lParen := p.expect(LPAREN)
+
+	var init Stmt
 	if p.tok == VAR {
-		x.Init = &DeclStmt{Decl: p.parseValueDecl()}
+		init = &DeclStmt{Decl: p.parseValueDecl()}
 	} else {
-		x.Init = &ExprStmt{Expr: p.parseExpr()}
+		init = &ExprStmt{Expr: p.parseExpr()}
+	}
+
+	if p.tok == IN {
+		if hasAssignment(init) {
+			p.error(p.peek(1), "unexpected token %s", p.tok)
+		}
+		x := new(ForRangeStmt)
+		x.Tok = forTok
+		x.LParen = lParen
+		x.Init = init
+		x.InTok = p.consume()
+		x.Range = p.parseExpr()
+		x.RParen = p.expect(RPAREN)
+		x.Body = p.parseBlockStmt()
+		return x
 	}
+
+	x := new(ForStmt)
+	x.Tok = forTok
+	x.LParen = lParen
+	x.Init = init
 	x.InitSemi = p.expect(SEMICOLON)
 	x.Cond = p.parseExpr()
 	x.CondSemi = p.expect(SEMICOLON)
@@ -2540,24 +2558,27 @@ func (p *parser) parseForLoop() *ForStmt {
 	return x
 }
 
-func (p *parser) parseForRangeLoop() *ForRangeStmt {
-	x := new(ForRangeStmt)
-	x.Tok = p.consume()
-	x.LParen = p.expect(LPAREN)
-	if p.tok == VAR {
-		x.VarTok = p.consume()
-		if p.peek(2).Kind() != IN {
-			x.Type = p.parseTypeSpec()
+func hasAssignment(n Node) bool {
+	switch n := n.(type) {
+	case *DeclStmt:
+		return hasAssignment(n.Decl)
+	case *ExprStmt:
+		return hasAssignment(n.Expr)
+	case *ValueDecl:
+		for _, d := range n.Decls {
+			if d.AssignTok != nil {
+				return true
+			}
 		}
-		x.Var = p.parseName()
-	} else {
-		x.Var = p.parseIdent()
+		return false
+	case *BinaryExpr:
+		if n.Op.Kind() == ASSIGN {
+			return true
+		}
+		return false
+	default:
+		return false
 	}
-	x.InTok = p.expect(IN)
-	x.Range = p.parseExpr()
-	x.RParen = p.expect(RPAREN)
-	x.Body = p.parseBlockStmt()
-	return x
 }
 
 func (p *parser) parseWhileLoop() *WhileStmt {

diff --git a/ttcn3/syntax/parser_test.go b/ttcn3/syntax/parser_test.go
@@ -282,8 +282,9 @@ func TestStmts(t *testing.T) {
 		{pass, `for (var int i := 0; i<23; i := i+1) {}`},
 		{pass, `for (i:=x; i<23; i:=i+1) {}`},
 		{pass, `for (x in {1,2,3}) {}`},
-		{pass, `for (var x in a) {}`},
+		{fail, `for (var x in a) {}`},
 		{pass, `for (var integer x in a) {}`},
+		{pass, `for (var template integer x in a) {}`},
 		{pass, `while (23) {}`},
 		{pass, `do {} while (23);`},
 		{pass, `if (1) {}`},