Removed pyc #8
Open
Removed pyc #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed initial pre-requisite install section
|
Is it intended to include PRO: CON: |
|
It wasn't intended. I did alter the URL you had in the readme which was
now invalid. Actually, given the fact this changes so frequently I would
be inclined to leave it in there with a note saying that it can be updated
if required at the URL.
Your thoughts? Ultimately the only changes intended here were to add
capabilities and get and change the structure to allow adding other modules
in a more structured/simple way.
I'm not precious about it of course so feel free to make any changes you
think are good
Cheers
James
…On 2 July 2018 at 10:23, wiso ***@***.***> wrote:
Is it intended to include gnmi_pb2.py in your delivery?
PRO:
Simplifies the installation process for customers...
CON:
File can be download straight from OpenConfig (gitHub) repository. If
people are interested in using a different gNMI version - it might be
beneficial for them to know, where to get the desired version of the .proto
and .py files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFALfYvW3SYpeYbet9HNKfLyDjgBSb-3ks5uCeaAgaJpZM4U-7Xt>
.
|
|
Have you checked your code against both python2.7 and python3? cheers |
|
No, only 2.7. Thanks - I know there are improvements to make but I needed
get and capabilities quickly and it seemed sensible to extend yours rather
than do something from scratch
…On 2 July 2018 at 10:28, wiso ***@***.***> wrote:
Have you checked your code against both python2.7 and python3?
I will do some testing later this week, before accepting this PR.
cheers
wiso
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFALfWERMNpG3_t0uYBKvIDefqkBXPJhks5uCefJgaJpZM4U-7Xt>
.
|
works for get although needs further value iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed PYC. Please review and ammend as desired. SET to follow