-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SATA link speeds #453
SATA link speeds #453
Conversation
Hi, thanks a lot, that's really cool and works really well! I managed to make a few code segments more compact, I hope you don't mind that I pushed it to your branch. :) Are you fine with that? |
Ah cool, this Yeah very nice! Thanks. |
I'll look into adding USB link info in a following PR. Seems also quite easy, and then I think the most important Link types are present. |
Sounds nice, looking forward to it! |
So could you explain why the Generics for PathBuf? And why the &str use with Path.as_ref()? |
It doesn't functionally change anything but allows anything that by referencing it can be turned to a |
Expanded a bit on the PCIe Link code to also support SATA speeds.
It was quite hard to get the actual
ata_link
property from sysfs. The only way I could find to get the ata device and then link was through reading the actual symlink for a/sys/class/block/x device
and then finding the\ataXX\
path and then thelinkXX
subdir of it. Which is somewhat hacky, but I am also too novice in Rust to make it less verbose. So feel free to suggest some changes there.I added a dependency, which seemed lightweight. It is used to be able to navigate to a joined Path with
../../
from the symlink in it.