Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to ensure that node is defined #419

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

nolanlawson
Copy link
Owner

#418 makes me a bit nervous but I can't seem to find any case in the Vitest tests at least where the node would be undefined... this adds a check to prove it.

Copy link

github-actions bot commented Apr 13, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -0% - +1% (-0.07ms - +0.25ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +5% (-4.72ms - +4.83ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -5% - +4% (-2.72ms - +2.12ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: slower ❌ 0% - 9% (0.21ms - 3.38ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.30ms - 33.55ms-unsure 🔍
-0% - +1%
-0.07ms - +0.25ms
tip-of-tree
tip-of-tree
33.24ms - 33.43msunsure 🔍
-1% - +0%
-0.25ms - +0.07ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
102.44ms - 109.53ms-unsure 🔍
-4% - +5%
-4.72ms - +4.83ms
tip-of-tree
tip-of-tree
102.74ms - 109.12msunsure 🔍
-5% - +4%
-4.83ms - +4.72ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.59ms - 53.99ms-unsure 🔍
-5% - +4%
-2.72ms - +2.12ms
tip-of-tree
tip-of-tree
50.87ms - 54.31msunsure 🔍
-4% - +5%
-2.12ms - +2.72ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
37.15ms - 39.15ms-slower ❌
0% - 9%
0.21ms - 3.38ms
tip-of-tree
tip-of-tree
35.12ms - 37.59msfaster ✔
1% - 9%
0.21ms - 3.38ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: 0 B

Total Size: 36.4 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 36.4 kB

compressed-size-action

@nolanlawson nolanlawson merged commit 028f4dc into master Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant