Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Access-Control-Allow-Headers to Access-Control-Expose-Headers in the readme #484

Merged

Conversation

ympek
Copy link
Contributor

@ympek ympek commented Dec 16, 2024

There is an error in the readme - incorrectly stating that the cross-origin server has to provide Access-Control-Allow-Headers, where the header we want is Access-Control-Expose-Headers

The HTTP Access-Control-Expose-Headers response header allows a server to indicate which response headers should be made available to scripts running in the browser in response to a cross-origin request.

I've also deleted the now-obsolete info about Safari not supporting the header

Best regards,
ympek

…ders in the readme, the latter being the correct header name
@nolanlawson
Copy link
Owner

D'oh! Thanks a bunch. Easy to mix these up. 😅

@nolanlawson nolanlawson merged commit ae637c7 into nolanlawson:master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants