Fix crash when an APIResource has no verbs #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasstockner
force-pushed
the
fix-apiresource-no-verbs
branch
from
e26c8af
to
592d57f
Compare
lukasstockner
force-pushed
the
fix-apiresource-no-verbs
branch
from
592d57f
to
e0254a7
Compare
Signed-off-by: Lukas Stockner <[email protected]>
lukasstockner
force-pushed
the
fix-apiresource-no-verbs
branch
from
e0254a7
to
e42d475
Compare
|
Sorry for the delay reviewing it. Released as 1.36.2. And thank you for the contribution! |
No worries, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a Kopf operator in a cluster that has a recent version of KubeVirt installed, it crashes on startup with
TypeError: 'NoneType' object is not iterable.The problem appears to be that KubeVirt registers an APIResource with no verbs, so the resource that is being fetched here contains
"verbs": None, which causes the code in_read_versionto fail.There are actually quite a few such resources, but all the others contain slashes in their name so the filter in line 124 ignores them, which is why it worked before KubeVirt v0.58.1.