refactor: fork tests can easily be modified to any chain #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
commented
Nov 29, 2022
| function setUp() public override(BridgeRouterBaseTest, NomadTest) { | ||
| setUpReboot("ethBridgeRouter"); | ||
| require( | ||
| keccak256(bytes(localDomainName)) == keccak256(bytes("ethereum")), | ||
| "not ethereum bridge router" |
There was a problem hiding this comment.
i don't think there's a skipTest cheat code, so allowing it to fail at setup (thus not run any tests) with a clear error message
There was a problem hiding this comment.
We can do an early return, which would count as successful.
There was a problem hiding this comment.
modifier skipNotEthereum() {
if (keccak256(bytes(localDomainName)) == keccak256(bytes("ethereum"))) {
_;
}
}
There was a problem hiding this comment.
we don't have access to localDomainName in the inherited unit tests. also, that would mean that the unit tests don't run
3 tasks
anna-carroll
force-pushed
the
anna/fork-multi
branch
from
6020f84
to
636ccb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'd like the ability to run the fork tests on any chain
Solution
Refactor to use CallBatch domain wherever possible so that the test domain can be changed in one single place in Reboot.t.sol.
PR Checklist