Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues running from pip install #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ItMightBeKaraoke
Copy link

  • pyproject.toml: lyrics_transcriber/utils/cli.py "import pkg_resources" depends on setuptools. Version spec may need to be updated, I just picked one roughly around python 3.9 era.
  • poetry.lock - Also missing setuptools dep
  • lyrics_transcriber/transcriber.py - the llm prompt paths are relative and if the user installed with pip, would only work if the user is in the site_packages directory

I don't have openai credits to fully test, but to reproduce the issue:

python3 -m venv venv
. venv/bin/activate # or activation script of choice
pip install lyrics-transcriber
lyrics-transcriber # ModuleNotFoundError: No module named 'pkg_resources'
pip install setuptools
lyrics-transcriber --artist ARTIST --title TITLE FILE # No such file or directory: 'lyrics_transcriber/llm_prompts/llm_prompt_lyrics_matching_andrew_handwritten_20231118.txt'

- pyproject.toml: lyrics_transcriber/utils/cli.py "import pkg_resources" depends on setuptools. Version spec may need to be updated, I just picked one roughly around python 3.9 era.
- lyrics_transcriber/transcriber.py - the llm prompt paths are relative and if the user installed with pip, would only work if the user is in the site_packages directory
@ItMightBeKaraoke
Copy link
Author

Ignore the previous PR that I closed. Same changes, but bad author metadata...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant