Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#43): force maxProperties greater than min #44

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix(#43): force maxProperties greater than min #44

merged 1 commit into from
Nov 14, 2023

Conversation

LoisSotoLopez
Copy link
Contributor

Issue #43

@LoisSotoLopez LoisSotoLopez linked an issue Nov 14, 2023 that may be closed by this pull request
Default maxProperties should not restrict the number of properties #43
Closed
javiergarea
javiergarea approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@javiergarea javiergarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@javiergarea javiergarea merged commit 7146104 into main Nov 14, 2023
1 check passed
@javiergarea javiergarea deleted the fix/43-default-max-properties branch November 14, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiergarea javiergarea javiergarea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default maxProperties should not restrict the number of properties
2 participants
@LoisSotoLopez @javiergarea