Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minja: update submodule to fix {# hang #3446

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

cebtenzzre
Copy link
Member

Update the minja submodule to the tip of google/minja#37, which includes my fix for the hang when attempting to set the chat template in settings to {#.

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre marked this pull request as ready for review January 31, 2025 17:48
@cebtenzzre cebtenzzre requested a review from manyoso January 31, 2025 17:48
@cebtenzzre cebtenzzre merged commit c38c745 into main Feb 3, 2025
4 of 12 checks passed
@cebtenzzre cebtenzzre deleted the fix-minja-opencomment branch February 3, 2025 16:25
cebtenzzre added a commit that referenced this pull request Feb 3, 2025
This reverts commit c38c745.

Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre restored the fix-minja-opencomment branch February 3, 2025 20:24
cgivre pushed a commit to cgivre/gpt4all that referenced this pull request Feb 4, 2025
cgivre pushed a commit to cgivre/gpt4all that referenced this pull request Feb 4, 2025
This reverts commit c38c745.

Signed-off-by: Jared Van Bortel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants