popover-fix popover open issue (#37)

nonfx · Oct 10, 2024 · a79c7f0 · a79c7f0
1 parent 8b214cc
commit a79c7f0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/packages/flow-core/CHANGELOG.md b/packages/flow-core/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 # Change Log
 
+## [2.11.4] - 2024-10-10
+
+### patch changes
+
+- overlay-click event behavior updated
+
 ## [2.11.3] - 2024-10-09
 
 ### patch changes

diff --git a/packages/flow-core/package.json b/packages/flow-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nonfx/flow-core",
-  "version": "2.11.3",
+  "version": "2.11.4",
   "description": "Core package of flow design system",
   "type": "module",
   "module": "dist/flow-core.es.js",

diff --git a/packages/flow-core/src/components/f-popover/f-popover.ts b/packages/flow-core/src/components/f-popover/f-popover.ts
@@ -377,7 +377,7 @@ export class FPopover extends FRoot {
 	}
 
 	outsideClick = (e: MouseEvent) => {
-		if (this.open) {
+		if (this.open && e?.target !== this.targetElement) {
 			const rect = this.getBoundingClientRect();
 			const isInsideClick =
 				e.clientX > rect.left &&

diff --git a/stories/flow-core/f-popover.stories.ts b/stories/flow-core/f-popover.stories.ts
@@ -31,6 +31,7 @@ export const Playground = {
 		const popoverRef = createRef<FPopover>();
 		const handlePopover = (_e: CustomEvent) => {
 			if (popoverRef.value) {
+				console.log("in handle popover");
 				popoverRef.value.open = !popoverRef.value.open;
 			}
 		};