NFX-405 f-search autocomplete issue fixed (#28)

nonfx · Sep 20, 2024 · d38ee51 · d38ee51
1 parent 5b82b04
commit d38ee51
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 10 deletions.
diff --git a/packages/flow-core/CHANGELOG.md b/packages/flow-core/CHANGELOG.md
@@ -2,6 +2,13 @@
 
 # Change Log
 
+## [2.10.17] - 2024-09-20
+
+### Patch Changes
+
+- `f-select` auto-complete removed from search input
+- `f-select` group search issue fixed.
+
 ## [2.10.16] - 2024-09-18
 
 ### Patch Changes

diff --git a/packages/flow-core/package.json b/packages/flow-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nonfx/flow-core",
-  "version": "2.10.16",
+  "version": "2.10.17",
   "description": "Core package of flow design system",
   "module": "dist/flow-core.es.js",
   "main": "dist/flow-core.cjs.js",

diff --git a/packages/flow-core/src/components/f-select/handlers.ts b/packages/flow-core/src/components/f-select/handlers.ts
@@ -251,26 +251,28 @@ export function handleInput(this: FSelect, e: InputEvent) {
 
 		if (Array.isArray(this.options)) {
 			this.filteredOptions = (this.options as FSelectArrayOfObjects)?.filter(
-				(item: FSelectSingleOption) =>
-					typeof item === "string"
+				(item: FSelectSingleOption) => {
+					return typeof item === "string"
 						? item.toLowerCase().includes((e.target as HTMLInputElement)?.value.toLowerCase())
 						: (item as FSelectOptionObject).title
 								.toLowerCase()
-								.includes((e.target as HTMLInputElement)?.value.toLowerCase())
+								.includes((e.target as HTMLInputElement)?.value.toLowerCase());
+				}
 			);
 		} else {
-			const filteredOptionsCloned = cloneDeep(this.filteredOptions);
+			const filteredOptionsCloned = cloneDeep(this.options);
 			Object.keys(this.options).forEach(item => {
 				(filteredOptionsCloned as FSelectOptionsGroup)[item] = (
 					(this.options as FSelectOptionsGroup)[item] as FSelectArrayOfObjects
-				)?.filter((obj: FSelectSingleOption) =>
-					typeof obj === "string"
+				)?.filter((obj: FSelectSingleOption) => {
+					return typeof obj === "string"
 						? obj.toLowerCase().includes((e.target as HTMLInputElement)?.value.toLowerCase())
 						: (obj as FSelectOptionObject).title
 								.toLowerCase()
-								.includes((e.target as HTMLInputElement)?.value.toLowerCase())
-				);
+								.includes((e.target as HTMLInputElement)?.value.toLowerCase());
+				});
 			});
+
 			this.filteredOptions = filteredOptionsCloned;
 		}
 		this.requestUpdate();

diff --git a/packages/flow-core/src/components/f-select/render.ts b/packages/flow-core/src/components/f-select/render.ts
@@ -115,6 +115,7 @@ export default function render(this: FSelect) {
 					: ""
 				: this.placeholder}
 			size=${this.size}
+			autocomplete="off"
 			?readonly=${!this.searchable}
 			.value=${this.searchValue}
 			@input=${this.handleInput}
@@ -294,7 +295,7 @@ export default function render(this: FSelect) {
 			 * Check if options is object of groups
 			 */
 			Object.keys(this.filteredOptions)?.length > 0 &&
-			Object.keys(this.filteredOptions)?.every(
+			Object.keys(this.filteredOptions)?.some(
 				groupName => (this.filteredOptions as FSelectOptionsGroup)[groupName].length > 0
 			)
 		) {