Merge pull request #7048 from nimrod-becker/backport_to_5_11

[Backport to 5.11] fix small mem leaks that accumulate

src/native/chunk/splitter_napi.cpp

@@ -11,6 +11,7 @@ namespace noobaa
 static Napi::Value _chunk_splitter(const Napi::CallbackInfo& info);
 static Napi::Value _splitter_finish(Napi::Env env, Splitter* splitter);
 static Napi::Value _splitter_result(Napi::Env env, Splitter* splitter);
+static void _free_splitter(Napi::Env env, Splitter* splitter);
 
 void
 splitter_napi(Napi::Env env, Napi::Object exports)
@@ -111,7 +112,7 @@ _chunk_splitter(const Napi::CallbackInfo& info)
             throw Napi::Error::New(info.Env(), "Invalid splitter config");
         }
         splitter = new Splitter(min_chunk, max_chunk, avg_chunk_bits, calc_md5, calc_sha256);
-        state["splitter"] = Napi::External<Splitter>::New(info.Env(), splitter);
+        state["splitter"] = Napi::External<Splitter>::New(info.Env(), splitter, _free_splitter);
     }
 
     auto buffers = info[1].As<Napi::Array>();
@@ -169,4 +170,10 @@ _splitter_result(Napi::Env env, Splitter* splitter)
     return arr;
 }
 
+static void 
+_free_splitter(Napi::Env env, Splitter* splitter)
+{
+    delete splitter;
+}
+
 } // namespace noobaa

src/native/fs/fs_napi.cpp

@@ -1156,21 +1156,30 @@ struct RealPath : public FSWorker
 
     RealPath(const Napi::CallbackInfo& info)
         : FSWorker(info)
+        , _full_path(0)
     {
         _path = info[1].As<Napi::String>();
         Begin(XSTR() << DVAL(_path));
     }
 
+    ~RealPath() {
+        if (_full_path) {
+            free(_full_path);
+            _full_path = 0;
+        }
+    }
+
     virtual void Work()
     {
+        // realpath called with resolved_path = NULL so it will malloc as needed for the result
+        // and we just need to make sure to capture this result and remember to free it on dtor.
         _full_path = realpath(_path.c_str(), NULL);
-        if (_full_path == NULL) SetSyscallError();
+        if (!_full_path) SetSyscallError();
     }
 
     virtual void OnOK()
     {
         DBG1("FS::RealPath::OnOK: " << DVAL(_path) << DVAL(_full_path));
-
         Napi::Env env = Env();
         auto res = Napi::String::New(env, _full_path);
         _deferred.Resolve(res);