Enhance restore_session logic with read_auth retries in case of RPC_C…

…ONNECT_TIMEOUT
noobaa · Jun 29, 2017 · fe6e6b2 · fe6e6b2
1 parent 23ae6fb
commit fe6e6b2
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 15 deletions.
diff --git a/frontend/src/app/config.json b/frontend/src/app/config.json
@@ -7,6 +7,7 @@
     "sslCertificateSuffix": ".zip",
     "upgradePackageSuffix": ".gz",
     "serverRestartWaitInterval": 20000,
+    "readAuthRetryCount": 2,
     "nodeTest": {
         "targetCount": 20,
         "testSettings": {

diff --git a/frontend/src/app/epics/restore-session.js b/frontend/src/app/epics/restore-session.js
@@ -3,27 +3,50 @@
 import api from 'services/api';
 import { RESTORE_SESSION } from 'action-types';
 import { completeRestoreSession, failResotreSession } from 'action-creators';
+import { readAuthRetryCount } from 'config';
+import Rx from 'rx';
+
+function _createUnauthorizedException(message) {
+    const error = new Error(message);
+    error.rpc_code = 'UNAUTHORIZED';
+    return error;
+}
 
 export default function(action$) {
     return action$
         .ofType(RESTORE_SESSION)
-        .flatMap(async action => {
+        .flatMap(action => {
             const { token } = action.payload;
+            if (!token) {
+                const error = _createUnauthorizedException('Token not available');
+                throw { token, error };
+            }
 
-            try {
-                api.options.auth_token = token;
-                const sessionInfo = await api.auth.read_auth();
-                if (!sessionInfo.account) {
-                    throw Object.assign(
-                        new Error('Account not found'),
-                        { rpc_code: 'UNAUTHORIZED'}
-                    );
-                }
+            api.options.auth_token = token;
+            return Rx.Observable.fromPromise(() => api.auth.read_auth())
+                .map(sessionInfo => {
+                    if (!sessionInfo.account) {
+                        throw _createUnauthorizedException('Account not found');
+                    }
 
-                return completeRestoreSession(token, sessionInfo);
+                    return completeRestoreSession(token, sessionInfo);
+                })
+                .retryWhen(errors => {
+                    return errors
+                        .scan((count, err) => {
+                            if (err.rpc_code !== 'RPC_CONNECT_TIMEOUT' || count >= readAuthRetryCount) {
+                                throw err;
+                            }
 
-            } catch (error) {
-                return failResotreSession(token, error);
-            }
-        });
+                            return count + 1;
+                        }, 0)
+                        .delay(1000);
+                })
+                .catch(error => {
+                    throw { token, error };
+                });
+        })
+        .catch(({ token, error }) => Rx.Observable.of(
+            failResotreSession(token, error)
+        ));
 }