Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Fix for NooBaa CLI not creating events #8671

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. A new config called EVENT_LOGGING_ENABLED was introduced on NC | NSFS | Panic Printings Added + Try-Catch memory_monitor + Change Default Event Logs + Increase LimitNOFILE #8518.
    As mentioned in the declaration of this configuration, config.EVENT_LOGGING_ENABLED = false; // should be changed in NC NSFS configuration - we need to enable it on Non-containerized environment, there was a bug that it was enabled only in nsfs.js and not in the CLI, therefore I enabled it on the CLI as well since no cli events were created due to this issue.

Issues: Fixed #xxx / Gap #xxx

  1. consider backport it to 5.17.

Testing Instructions:

  1. Run CLI and expect to see events.
    Example -
    noobaa-cli account add --name=account1 --new_buckets_path=/private/tmp/dir2/ --user=root
    expect to see in the logs the following event -
Jan-9 10:26:07.836 [/25144] [EVENT]{"timestamp":"2025-01-09T08:26:07.836Z","host":"hostname1","event":{"code":"noobaa_account_created","message":"Account created","description":"Noobaa Account created","entity_type":"NODE","event_type":"INFO","scope":"NODE","severity":"INFO","state":"HEALTHY","arguments":{"account":"account1"},"pid":25144}}
  • Doc added/updated
  • Tests added

Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit cf83c72 into noobaa:master Jan 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants