NC | Fix for NooBaa CLI not creating events #8671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
EVENT_LOGGING_ENABLED
was introduced on NC | NSFS | Panic Printings Added + Try-Catchmemory_monitor
+ Change Default Event Logs + IncreaseLimitNOFILE
#8518.As mentioned in the declaration of this configuration,
config.EVENT_LOGGING_ENABLED = false; // should be changed in NC NSFS configuration
- we need to enable it on Non-containerized environment, there was a bug that it was enabled only in nsfs.js and not in the CLI, therefore I enabled it on the CLI as well since no cli events were created due to this issue.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Example -
noobaa-cli account add --name=account1 --new_buckets_path=/private/tmp/dir2/ --user=root
expect to see in the logs the following event -