Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic support for working with external postgres DB #1179

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

jackyalbo
Copy link
Contributor

Explain the changes

  1. Adding support to provide a secret reference to a postgres DB URL in noobaa CRD. The secret has to have a key called "db_url" and to be in this format: potgres://user:password@full DNS name of external server:port/db-name
  2. Adding a CLI option to add postgres-url in the same format in 1. for example:
noobaa install --postgres-url="postgres://postgres:GWHMacB1ajy1SkY4Q5FH4myc60lJHTbF3I99LLCCwnLj32Je815cWd92JeQeBSiz@externalserver.namespace.svc:5432/nbcore"

CLI will create the expected secret and attach it to the noobaa system CRD

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@liranmauda
Copy link
Contributor

@t-pirhonen @lallinger-arbeit you might find this helpful

@jackyalbo jackyalbo force-pushed the jacky-fix8 branch 2 times, most recently from 5617396 to 6e29f92 Compare July 26, 2023 07:54
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/system/phase2_creating.go Outdated Show resolved Hide resolved
pkg/system/system.go Outdated Show resolved Hide resolved
@jackyalbo jackyalbo merged commit 3f6f74b into noobaa:master Jul 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants