Pass Region Param to External Connection #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
shirady
force-pushed
the
add-region-to-schema
branch
from
1e6e499
to
3a3aafa
Compare
dannyzaken
approved these changes
Aug 14, 2023
pass region to update external connection Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
add-region-to-schema
branch
from
3a3aafa
to
e8eeb75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Need to build with noobaa change noobaa/noobaa-core#7433.
Note:
nbis an alias that runs the local operator frombuild/_output/bin(alias created bydevenv).nb namespacestore create aws-s3 <namespace-store-name> --region=<target-bucket-region>.nb backingstore create aws-s3 <backingstore-store-name> --region=<target-bucket-region>.check_external_connection,check_aws_connectionand see that the region passed.Note: test on buckets in the regions 'us-east-1' and 'us-west-1'.