Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip hpav2 resources if metrics type is Resource #1190

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Skip hpav2 resources if metrics type is Resource #1190

merged 1 commit into from
Aug 10, 2023

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. Skip hpav2 resources creation if the metrics type is Resource

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2228805#c2

Testing Instructions:

  1. install noobaa and Prometheus adaptor should not be created if metrics type is Resource
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 merged commit c29048f into noobaa:master Aug 10, 2023
14 checks passed
@dannyzaken dannyzaken mentioned this pull request Aug 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveenpaul1 @dannyzaken