Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #432 POSTGRES_HOST use service url with namespace #1450

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix #432 POSTGRES_HOST use service url with namespace #1450

merged 1 commit into from
Sep 30, 2024

Conversation

guymguym
Copy link
Member

Explain the changes

  1. use service url with namespace for POSTGRES_HOST to fix for GKE

Issues: Fixed #xxx / Gap #xxx

  1. Fixes [BUG] NooBaa is not working in GKE #432

Testing Instructions:

  1. Deploy in GKE
  • Doc added/updated
  • Tests added

liranmauda
liranmauda approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guymguym guymguym merged commit d993129 into master Sep 30, 2024
27 checks passed
@guymguym guymguym deleted the guymguym-fix-432 branch September 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@dannyzaken dannyzaken dannyzaken approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NooBaa is not working in GKE
3 participants
@guymguym @dannyzaken @liranmauda