Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #432: Change db service to headless needed to get direct pod dns name on GKE #1454

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Oct 1, 2024

Explain the changes

  1. Without this on GKE we don't get the DNS name of the pod created noobaa-db-pg-0.noobaa-db-pg.<namespace>.svc
  2. see https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-hostname-and-subdomain-fields
  3. see https://kubernetes.io/docs/concepts/services-networking/service/#headless-services
  4. For some reason on Openshift this works also for non-headless service, but on GKE it won't generate the DNS for the pods unless it's headless (see with kubectl get endpointslices).

Issues: Fixed #xxx / Gap #xxx

  1. Fixes [BUG] NooBaa is not working in GKE #432

Testing Instructions:

  1. Deploy on GKE

@guymguym guymguym changed the title Fix #432: Change db service to headless as expected to get direct pod dns name on gke Fix #432: Change db service to headless needed to get direct pod dns name on GKE Oct 1, 2024
@roveicy93
Copy link

Hi @guymguym , please let me know when we can test this fix. Thank you for your kind support.

@guymguym guymguym merged commit d7dae26 into noobaa:master Oct 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NooBaa is not working in GKE
3 participants