Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy check for endpoint and removed duplicate code #1455

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Oct 3, 2024

Explain the changes

  1. We have added a proxy status check for the endpoint and removed the duplicate code.

Screenshot from 2024-10-07 14-52-39

Issues: Fixed #xxx / Gap #xxx

  1. Enhancement: Added a CLI sub-command in noobaa diagnostics to print proxy details #1440
  2. Enhancement: Printing overrided vars in cli command noobaa diagnostics report #1445

Testing Instructions:

  1. After installing noobaa run the cli command noobaa diagnostics report to see the output.

@achouhan09 achouhan09 requested review from Neon-White, liranmauda, shirady, a team and nbecker-cibot and removed request for a team October 3, 2024 11:15
@achouhan09 achouhan09 requested review from aspandey and removed request for nbecker-cibot October 3, 2024 11:16
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranmauda
Copy link
Contributor

Do not forget to squash the commits.

@achouhan09 achouhan09 merged commit 0ae4f76 into noobaa:master Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants