Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating controller-runtime to v0.19.0 #1461

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Oct 13, 2024

Explain the changes

Updating controller-runtime to v0.19.0

controller-runtime added a name verification.
All noobaa controllers are named the same (noobaa-controller) which leads to Controller names must be unique to avoid multiple controllers reporting to the same metric

there are 2 options:

  1. Set a different name
  2. set:
controller.Options{
		SkipNameValidation: &[]bool{true}[0],
	}

For now, I plan to skip the validation, If we see a value to change it later to use a different name per controller (we could open a gap).

Signed-off-by: liranmauda [email protected]

Updating controller-runtime to v0.19.0
Signed-off-by: liranmauda <[email protected]>
@liranmauda liranmauda merged commit c611e73 into noobaa:master Oct 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants