Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs | STS | Update Docs (Noobaa Core Service Account Name Changed) #1466

Merged

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Oct 29, 2024

Explain the changes

  1. In PR Fixing SCC issues for bucket logging #1391 the service account name of statefulset-core.yaml was changed from "noobaa" to 'noobaa-core" (see here), hence we update the existing docs related to AWS STS.
  2. Added a comment near the service account name, in case someone would change it so it would know that there additional actions and impact on users of existing deployed AWS STS clusters for this change.
  3. Added a section in the troubleshooting for such case, or for partial trust policy (that doesn't have the new service account).

Issues:

  1. Was raised as a part of BZ 2322124.
  2. GAP - worth improving the of the variables name in the doc script (as mention in the comment below).

Testing Instructions:

  1. none
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Oct 29, 2024
@shirady shirady force-pushed the update-sts-docs-core-service-account-name branch from 30c3c83 to 503521b Compare October 29, 2024 07:12
doc/dev_guide/troubleshoot_sts_cluster.md Outdated Show resolved Hide resolved
doc/dev_guide/create_aws_role.sh Show resolved Hide resolved
1. In PR Fixing SCC issues for bucket logging noobaa#1391 the service account name of statefulset-core.yaml was changed from "noobaa" to 'noobaa-core" (see here), hence we update the existing docs related to AWS STS.
2. Added a comment near the service account name, in case someone would change it so it would know that there additional actions and impact on users of existing deployed AWS STS clusters for this change.
3. Added a section in the troubleshooting for such case, or for partial trust policy (that doesn't have the new service account).

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the update-sts-docs-core-service-account-name branch from 44a5f01 to e0a4df4 Compare October 29, 2024 10:10
@shirady shirady merged commit 2118852 into noobaa:master Oct 30, 2024
14 checks passed
@shirady shirady deleted the update-sts-docs-core-service-account-name branch October 30, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants