feat: caches weather with redis & info tooltip #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Erb3
approved these changes
Nov 8, 2023
| if (!cachedWeatherData) { | ||
| const weatherData = await getCurrentWeatherData(input); | ||
| const secondsUntilMidnight = Math.round( | ||
| (new Date().setHours(24, 0, 0, 0) - Date.now()) / 1000, |
There was a problem hiding this comment.
This is a quite long and confusing line. The code below isn't shorter, but it is more understandable!
import { Interval, DateTime } from "luxon"
const secondsUntilMidnight = Interval.fromDateTimes(
DateTime.now(),
DateTime.now().endOf("day")
).length("seconds")
There was a problem hiding this comment.
tbh I would rather not need to install another package into the project and for maintenance sake, just use what javascript gave us out of the box, the variable naming is very descriptive of what the operation does so I don't think we necessarily need luxon.
|
Closes #355, please link |
Erb3
pushed a commit
to Erb3-forked/noodle-legacy
that referenced
this pull request
May 14, 2024
* feat: caches weather with redis & info tooltip * refactor: literally dropped by 50 lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
This PR aims to do the following: