feat: add clerk integration in /next branch #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Noodle Team on Vercel. A member of the Team first needs to authorize it. |
ixahmedxi
requested changes
May 18, 2024
There was a problem hiding this comment.
Thanks for the PR, there are some changes that need to be done however:
- add sign in / sign up pages for clerk.
- add clerk environment variables to env.ts.
- make the middleware only run on routes that start with /app because we wouldn't want to rate limit or check for authentication outside of that.
I also so see that you have also copied over the upstash rate limiting flow, I would change up the PR scope/title to match this then, something like feat: adds clerk & upstash integrations
|
@ixahmedxi I have made the changes you suggested, please let me know if anything more needs to be done:) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ixahmedxi
approved these changes
May 25, 2024
ixahmedxi
added a commit
that referenced
this pull request
Jun 7, 2024
* feat: initial commit for next branch * chore: adds .ds_store files to .gitignore * feat: todos in readme * feat: initialises gh actions * fix: cspell config formatting * chore: mark gh actions task as completed * feat: initialises playwright e2e testing * fix: bun test should run only on spec files in src * refactor: name playwright upload artifact step * refactor: move home page under (marketing) * feat: adds proper seo handling This commit brings the following changes: - Adds proper seo handling - Adds pink & salmon custom color palettes to tailwind. - Adds construct metadata utility function. - Enables react strict mode and disables eslint & typescript checks in next config. - Adds favicon, thumbnail images. * feat: initialises work on new marketing pages * fix: lint * fix: e2e tests * chore: adds playwright folders to clean script * chore: updates all dependencies * feat: adds red color scales made by kami * refactor: makes indigo glow bigger * feat: button primitive & usage on home page * feat: blur navbar on scroll & light/dark dashboard preview image * feat: add clerk integration in /next branch (#364) * feat: add clerk integration in /next branch * feat: add signin & signup pages, add env variables to env.ts * feat: adds env variables example * feat: dashboard page initialisation * fix: ci environment in pipeline * fix: exposes clerk & upstash env vars to ci * chore: remove forms tailwind plugin --------- Co-authored-by: ManavJoshi <[email protected]> Co-authored-by: Ahmed Elsakaan <[email protected]> * refactor: next clerk publishable key to vars * chore: update todos * chore: removes jsdoc & tailwindcss prettier plugins because eslint * feat: drizzle-orm/neon db integration * fix: run main ci on next branch * feat: adds db url to env example * feat: trpc api * feat: better auth routes organisation * feat: resend & react email integration * fix: adds resend api key to gh workflows * feat: better colours, light mode support & db schema * feat: early access page * chore: trust postinstall scripts * chore: updates deps * feat: early access page title * feat: refine todos in readme * feat: new todo * chore: exclude branch_out file * feat: progress towards the landing page * feat: navbar & features * fix: hydration error * feat: responsiveness in landing page * feat: desktop footer * feat: responsiveness * fix: lint * chore: updates deps * feat: mobile navbar * fix: adds missing mobile nav links * feat: final navbar touches * chore: updates deps * chore: updates deps * fix: makes footer at bottom if content size < screen size * feat: tos & privacy policy * chore: updates todos * chore: update .env.example * fix: hydration error * feat: wip blog with next-mdx-remote * feat: blogs page * feat: blog post * chore: remove unused stuff with next.config.js * feat: sentry * fix: ci environment vars * 404 not found * feat: ship it * chore: update readme * fix: lint --------- Co-authored-by: Manav H Joshi <[email protected]> Co-authored-by: ManavJoshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #363
This PR will add the clerk authentication in the /next branch.