Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: propose change commitMessage #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Kiruel
Copy link

@Kiruel Kiruel commented Jan 24, 2023

If we want to respect the convention for commit message, the scope should be on first position when exist, then I propose to add the emoji inside the parentheses.

So before this PRs:
:sparkles: feat: commit message

After:
feat(:sparkles:): commit message

@noomly
Copy link
Owner

noomly commented Jan 24, 2023

Koumu didn't have any plan initially to support a commit convention other than the one it's defining. I'm not against having different conventions available in Koumu though. But implementing this would mean making it configurable and respected both in the hooks and in the cli, which would involve bigger changes than simply editing the output of the commit command. That being said, I don't need this feature myself so I wont personally work on this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants