Repairing paths and adding PathBase #6868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask you to implement this? |
|
@skoshelev @AndreiMaz Can I ask you to verify this PR? |
skoshelev
added
refactoring / source code
and removed
discussion / investigation
labels
|
Hi @Alerinos. We have looked over the issue and your proposed solution. Thank you very much for your help, persistence, and patience. I will review the changes and merge your pull request before the release of version 4.80 |
exileDev
added a commit
that referenced
this pull request
Nov 6, 2024
exileDev
added a commit
that referenced
this pull request
Nov 6, 2024
DmitriyKulagin
added a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently published a PR that was not even reviewed.
I received feedback that everything can be done in the nginx configuration. Unfortunately, I did not receive an answer as well as a source in the documentation. I looked for it myself and there are many problems.
Even if you can do in nginx path base, the system is not designed for this and many places are all rigid.
I spent a lot of time debugging and looking for problems and my previous PR was closed just like that and I was mega pounced upon.
I find that I will post it again. Community should be supported and not overlooked.
Please check the PR correctly as well as if it was denied justify it.
My previous PR: #6852
@AndreiMaz @exileDev