Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topic index issue #7296

Closed
wants to merge 1 commit into from
Closed

Conversation

nirzaf
Copy link

@nirzaf nirzaf commented Aug 13, 2024

Fixes #7294

Update TopicTemplateBuilder.cs, Indexes.cs, and SchemaMigration.cs to add an index on Topic.SystemName by changing its type to nvarchar(400).

  • TopicTemplateBuilder.cs

    • Add SystemName column definition with nvarchar(400) in MapEntity method.
  • Indexes.cs

    • Add index creation for Topic.SystemName in Up method.
  • SchemaMigration.cs

    • Alter SystemName column to nvarchar(400) in Up method.

Fixes nopSolutions#7294

Update `TopicTemplateBuilder.cs`, `Indexes.cs`, and `SchemaMigration.cs` to add an index on `Topic.SystemName` by changing its type to `nvarchar(400)`.

* **TopicTemplateBuilder.cs**
  - Add `SystemName` column definition with `nvarchar(400)` in `MapEntity` method.

* **Indexes.cs**
  - Add index creation for `Topic.SystemName` in `Up` method.

* **SchemaMigration.cs**
  - Alter `SystemName` column to `nvarchar(400)` in `Up` method.
@RomanovM RomanovM assigned skoshelev and exileDev and unassigned skoshelev Aug 13, 2024
@exileDev exileDev self-requested a review September 4, 2024 12:09
@exileDev exileDev closed this Oct 22, 2024
exileDev added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add index on Topic.SystemName becase it's nvarchar(max)
3 participants