Connect wizard #23
Merged
Connect wizard #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
…rking" This reverts commit b874224.
This reverts commit 5fe3169.
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
Signed-off-by: Max Winter <[email protected]>
…put; changed error handling to use anyhow instead of error messages
…ct and disconnect commands unnecessary. Device is automatically unmounted after the program exits
|
Great work, thank you guys! We will review asap. |
… to main class; implemented clippy suggestions
… lib/src/connect.rs
satukoskinen
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
I tested the connect + device functionality and to me it looks like it's working well! I put a few small comments that can be fixed later on.
Some ideas for identifying the correct device:
- We could try to think of some way to restrict the provided manually listed devices to USB storage devices. For example
udevadm info <device/path>provides more information about each device. - Alternative or additional way to verify that the device is indeed the hydrophonitor device (and its correct partition)
udevadm info <device/path>can be used to check whetherID_FS_LABEL=NIXOS_SDis set
juliuskoskela
approved these changes
Feb 19, 2024
|
Changes approved, could developer please squash and merge the commits. Include necessary descriptions and commit messages in squashed commit (Github will give a template). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented connect wizard and clean command
Daniel and i thought about a different usage of the connect wizard:
The connect wizard no longer requires the usage of separate connect and disconnect commands.
Instead, the connect wizard is integrated in all other commands and automatically executed when no device is specified.
The connect wizard needs sudo rights because of the mounting.
We changed the mount location to /var/lib/hydrophonitor/device that the root user home directory doesn't get used.