Create deployment-specific directories to write files to #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
satukoskinen
commented
Jan 17, 2024
satukoskinen
commented
- Before, files were written to recording type specific subdirectories under /output. Now, a new timestamped directory will be created for each deployment (=boot) under which directories for audio, gps, depth, and logs will be created
- Create deployment-start service that runs before recording services start and which creates the deployment directory and exports it as an environment variable that can be read by other systemd services
- Update file & directory timestamp format to %Y-%m-%dT%H_%M_%S%z
satukoskinen
force-pushed
the
35-refactor-data-recording-output-directories
branch
from
8b7fd44 to
498f5a0
Compare
- Before, files were written to recording type specific subdirectories under /output. Now, a new timestamped directory will be created for each deployment (=boot) under which directories for audio, gps, depth, and logs will be created - Create deployment-start service that runs before recording services start and which creates the deployment directory and exports it as an environment variable that can be read by other systemd services - Update file & directory timestamp format to %Y-%m-%dT%H_%M_%S%z Signed-off-by: Satu Koskinen <[email protected]>
- audio-recorder and journalctl-log-export start after deployment-start service Signed-off-by: Satu Koskinen <[email protected]>
- Update flake inputs - Update depth-recorder and gps-recorder to use versions from correct branch for deployment directory changes - Update deployment-start service output-folder option description Signed-off-by: Satu Koskinen <[email protected]>
- all services now updated to use deploy-specific output directories - deploy.sh deploys changes to target raspberry pi, assuming user name "kaskelotti" and accepting as command line argument target IP address Signed-off-by: Satu Koskinen <[email protected]>
satukoskinen
force-pushed
the
35-refactor-data-recording-output-directories
branch
from
498f5a0 to
d58b196
Compare
Signed-off-by: Satu Koskinen <[email protected]>
juliuskoskela
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Could we have some comments in this file to explain what is being done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.