Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GitHub checks minus apply #1

Closed
wants to merge 25 commits into from
Closed

fix: GitHub checks minus apply #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4512ff4
fix: GitHub checks minus apply
henriklundstrom Jan 25, 2024
9f6d529
Do review descision together with status checks
henriklundstrom Jan 26, 2024
f2662fc
Make the current tests pass
henriklundstrom Jan 26, 2024
2ad0148
Move GraphQL test response to separate file
henriklundstrom Jan 26, 2024
64f9560
Remove obsolete things
henriklundstrom Jan 26, 2024
80b3934
Use a switch statement
henriklundstrom Jan 26, 2024
e87dd73
no need for status when we have conclusion
henriklundstrom Jan 30, 2024
670b40c
support multiple mergability responses in test
henriklundstrom Jan 30, 2024
7dd25dd
add test cases for different rollups
henriklundstrom Jan 30, 2024
0b6005f
set review decision to null by default in tests
henriklundstrom Jan 31, 2024
ff24808
use quoted string
henriklundstrom Jan 31, 2024
080b3f3
Merge branch 'main' into f/henriklundstrom/fix-required-checks-minus-…
henriklundstrom Feb 13, 2024
d288d6c
Disregard skipped checks
henriklundstrom Feb 16, 2024
b6c93fa
Handle expected checks (but not from workflows)
henriklundstrom Feb 23, 2024
58042ef
Handle expected required workflows
henriklundstrom Feb 26, 2024
1558d54
Cache repo ids
henriklundstrom Feb 26, 2024
c44e848
add logging
henriklundstrom Feb 28, 2024
5c0b48e
better error messages
henriklundstrom Feb 29, 2024
a22828d
fix: GitHub mergeability for expected checks from rulesets & branch p…
henriklundstrom Mar 1, 2024
fd3a7ea
Merge branch 'main' into f/henriklundstrom/fix-required-checks-minus-…
henriklundstrom Mar 1, 2024
ccf970a
only consider branch protection and active rulesets (#3)
henriklundstrom Mar 27, 2024
1d85f60
consider neutral as passing
henriklundstrom Mar 28, 2024
d5398eb
Merge branch 'main' into f/henriklundstrom/fix-required-checks-minus-…
henriklundstrom Mar 28, 2024
bc44e6f
Merge branch 'main' into f/henriklundstrom/fix-required-checks-minus-…
henriklundstrom May 15, 2024
231e9a0
Merge branch 'main' into f/henriklundstrom/fix-required-checks-minus-…
henriklundstrom Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
445 changes: 350 additions & 95 deletions server/events/vcs/github_client.go
View file
Open in desktop

Large diffs are not rendered by default.

314 changes: 145 additions & 169 deletions server/events/vcs/github_client_test.go
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 0 additions & 10 deletions server/events/vcs/testdata/github-branch-protection-no-required-checks.json
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions server/events/vcs/testdata/github-branch-protection-required-checks.json
View file
Open in desktop

This file was deleted.

95 changes: 0 additions & 95 deletions server/events/vcs/testdata/github-commit-check-suites-check-runs-completed.json
View file
Open in desktop

This file was deleted.

169 changes: 0 additions & 169 deletions server/events/vcs/testdata/github-commit-check-suites-completed.json
View file
Open in desktop

This file was deleted.

Loading