Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8, example #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PEP8, example #12

wants to merge 7 commits into from

Conversation

14DF397FCA
Copy link

No description provided.

@acalm
Copy link
Contributor

acalm commented Dec 13, 2019

I've lost my merge super powers, which is perfectly fine since I have no means of testing the changes and no longer associated with the owning organization. However, this PR looks good to me, except for the use of f-strings. Yes, I know it's only in the readme, it may however confuse people and promote it's usage, useful as f-stings may be, they are not backwards compatible, even within the python3 world.

@14DF397FCA
Copy link
Author

It's sad story.
I hope anybody with write access will merge this request)

Yes, you right about f-strings and I updated readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants