Fix Invalid face box error
#131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `style` attribute `sunken-button` for the `:box` attribute set on a `button` or `custom-button*` is not a valid value[1]. This was not made manifest by a bug[2] on the emacs side but is expected to be fixed and become an error in the version 30 release. In the context of the code, `sunken-button` itself is considered equivalent to `pressed-button`, so all places where `sunken-button` is specified have been replaced with `pressed-button`. [1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Face-Attributes.html [2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67404
cariandrum22
changed the title
Invalid face box error (#130)Invalid face box error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
styleattributesunken-buttonfor the:boxattribute set on abuttonorcustom-button*is not a valid value1.This was not made manifest by a bug2 on the emacs side but is expected to be fixed and become an error in the version 30 release.
In the context of the code,
sunken-buttonitself is considered equivalent topressed-button, so all places wheresunken-buttonis specified have been replaced withpressed-button.