Use display-color-cells to enable 24-bit color terminal support
#64
Conversation
|
I see this PR has been here for a while. Are there someone with write access here that could do a review? It would be nice to see if this PR solves #64 as well. |
@arcticicestudio I've been using this for about year now. More so, I even need to use this fix, given #59. |
|
Sorry for the enormous delays, but "real life" keeps me busy almost ~18h a day 😟 Anyway, I promise to review, reproduce and test this PR no later than Saturday afternoon. I've seen a lot of forks of this repository only for this fix and many users approved the problems was resolved using the changes from this PR so I guess it'll work the way it should without breaking any other users setup. |
arcticicestudio
added
scope-compatibility
scope-stability
status-reproduction
type-improvement
and removed
scope-ux
labels
There was a problem hiding this comment.
Hi @visigoth 👋, thanks a lot for your contribution 👍
Sorry for the large delay, but my free time has been really limited the last year.
Based on the feedback and test in #59 your PR seem to partially fix the loading problem.
Anyway, before merging please see the review comments I've added so we can get this fix into the next release version.
| @@ -450,6 +454,11 @@ | |||
| `(web-mode-variable-name-face ((,class (:foreground ,nord-variable)))) | |||
|
|
|||
| ;; +--- UI ---+ | |||
|
|
|||
| ;; > ace-jump-mode | |||
There was a problem hiding this comment.
Please remove this additional style block and maybe submit a new PR if you'd like to add support for the package to Nord.
| @@ -480,6 +489,19 @@ | |||
| `(diff-hl-change ((,class (:background ,nord13)))) | |||
| `(diff-hl-insert ((,class (:background ,nord14)))) | |||
| `(diff-hl-delete ((,class (:background ,nord11)))) | |||
|
|
|||
| ;; > diredp | |||
There was a problem hiding this comment.
Same like above: Please also remove this additional style block.
|
@visigoth I can also go ahead and rebase your PR on |
|
Since the source branch of this PR is not a feature branch but the default branch visigoth/nord-emacs@develop there's no way for me to update the required PR changes. I'll create a new branch based on this PR and open a new PR to superseed this one. |
|
Superseded by #88. |
This change enables the use of nord-theme with emacs' new 24-bit color terminal support.