Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small color improvements #38

Closed
wants to merge 1 commit into from
Closed

Small color improvements #38

wants to merge 1 commit into from

Conversation

peterdanis
Copy link

Hi,

I like your theme, really nice. I have made small changes to some colors, please review & accept if you like them.

  1. As difference between variable.other.object and support.function in js file was not noticeable, I propose to change colors from #8FBCBB to #ABB8BA in all occurrences.
  2. In my opinion comments are too dark, barely noticeable, color changed to #646F7E.
  3. Editor snap-in color was same as background color and the snap size was not visible, editorGroup.dropBackground color change to #4C566A fixes this.

Before:
image

After:
image

Thank you.

- overal color change from #8FBCBB to #ABB8BA
-  make comments brighter, color change to #646F7E
- editorGroup.dropBackground color change to #4C566A
@peterdanis peterdanis closed this Sep 23, 2017
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Sep 24, 2017

Thanks for your contribution 👍
Sorry for my late reply, currently the time I can spend on my projects is rare.

  1. Variables and objects are colored with nord4, but VS Code seem to mix them with static function calls in this case and colored it (date) with nord7 which is used for classes.
  2. Please read and subscribe to Comments not different enough. #14.
  3. I've created Snap-in window is not visible #40 and resolved it 😄

This theme is a port project of the Nord color palette and the changed colors are not compatible anyway.

I'm sorry that I can't accept this PR, please try to open a issue per each list item to keep it clean and prevent you from spending time working on something that the core team members and project owner might not can and want to merge into the project.

GitHub has these really awesome and well-written Open Source Guides. If this was your first contribution I can recommend to read the chapter on how to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants