Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firmware version - call port.open() before querying it #176

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

alexrudd2
Copy link
Collaborator

Closes #124 ... mostly.

The CLI will still throw an error (throw new Error("TODO")), but it will at least print the firmware version before doing so.

❯ npx . --firmware-version
EBBv13_and_above EB Firmware Version 2.8.1
/Users/a.ruddick/Documents/github/saxi/dist/server/ebb.js:73
            throw new Error("TODO");

@andypiper
Copy link

Working as described above, for me. 👍🏻

@nornagon nornagon merged commit 09ccd5f into nornagon:main Oct 26, 2023
4 checks passed
@alexrudd2 alexrudd2 deleted the fix-firmware-check branch October 26, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running saxi --firmware-version command
3 participants