Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PLC0205: Class __slots__ should be a non-string iterable #945

Merged
merged 1 commit into from
Jul 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix PLC0205: Class __slots__ should be a non-string iterable
ogenstad committed Jul 1, 2024
commit 119205bed698c728e7f189ea4d6a09dcf4f4181b
2 changes: 1 addition & 1 deletion nornir/core/configuration.py
Original file line number Diff line number Diff line change
@@ -211,7 +211,7 @@ def dict(self) -> Dict[str, Any]:


class CoreConfig:
__slots__ = "raise_on_error"
__slots__ = ("raise_on_error",)

class Parameters:
raise_on_error = Parameter(default=False, envvar="NORNIR_CORE_RAISE_ON_ERROR")
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -161,7 +161,6 @@ ignore = [
"PERF203", # `try`-`except` within a loop incurs performance overhead
"PGH004", # Use specific rule codes when using `noqa`
"PIE800", # Unnecessary spread `**`
"PLC0205", # Class `__slots__` should be a non-string iterable
"PLC2801", # Unnecessary dunder call to `__getattribute__`. Access attribute directly or use getattr built-in function
"PLR6201", # Use a `set` literal when testing for membership
"PLR6301", # Method `run` could be a function, class method, or static method