Drafting updates to template #65
Conversation
|
Commit messages should be all lowercase in the first line and say what you changed, not what you did |
|
Other than that looks good |
andrlime
force-pushed
the
al-template-changes
branch
from
c8d5408 to
ea55085
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
========================================
- Coverage 1.02% 0.99% -0.04%
========================================
Files 10 11 +1
Lines 391 403 +12
========================================
Hits 4 4
- Misses 387 399 +12 ☔ View full report in Codecov by Sentry. |
web/public/template.py
Outdated
| @@ -23,12 +23,15 @@ def place_market_order(side: str, ticker: str, quantity: float, price: float) -> | |||
| class Strategy: | |||
| """Template for a strategy.""" | |||
|
|
|||
| def __init__(self) -> None: | |||
| def __init__(self, holdings) -> None: | |||
There was a problem hiding this comment.
I don't know what the type of holdings is
There was a problem hiding this comment.
remove it we dont need it
tried fixing linter issue fixed linter issue
Rebasing... Fixed rebase issues Fixing rebase
stevenewald
force-pushed
the
al-template-changes
branch
from
48904c3 to
ba734e6
Compare
stevenewald
force-pushed
the
al-template-changes
branch
from
8f3bc7d to
8937384
Compare
stevenewald
force-pushed
the
al-template-changes
branch
from
8937384 to
5e84f0b
Compare
|
Will merge once we complete initial run of nutc |
|
Will reopen this later. This will make old submissions not work so it'll be harder to test on prev results. We will use this, just not for a month or so. |
Work in progress updates to the template, there are some blanks to be filled in including types, docstrings, etc.