Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync functionality #296

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ianrandmckenzie
Copy link

@ianrandmckenzie ianrandmckenzie commented Sep 3, 2022

Hi there,

This pull request is incomplete - more so a beginning to a conversation that will hopefully lead to a merge after some fixes to this PR.

I had a lot of difficulty adding this since I wasn't sure how to make this stylistically similar to the northworld repo. Event list calls traditionally return an array, but with syncing, it's important to also receive nextPageToken and nextSyncToken in the responses, meaning a hash is more appropriate.

I am looking for suggestions on how to make it more northworld-y. Once that is done, I will add all applicable tests and notify when I am ready for a review with the intention of merging.

The code I wrote is based on the supporting docs here:
https://developers.google.com/calendar/api/guides/sync

Thank you for your time,

Ian

@ianrandmckenzie
Copy link
Author

@justinh24 tagging since I'm not sure if anyone has seen this.

@ianrandmckenzie
Copy link
Author

ianrandmckenzie commented Jul 17, 2023

@szich @justinh24 I'm cleaning up old unused repo's on my file. Wondering if I should let go of this PR or not. Looking for guidance or a 'no thanks' will suffice. Thanks!

@justinh24
Copy link
Member

@ianrandmckenzie Sorry for the very delayed response. @szich and I have been swamped in our day jobs. We don't need this feature, but could see where others might. We don't have the time to finish it. If you wanted to complete it, we would happily test and merge it into the Gem.

Thank you for submitting.

@ianrandmckenzie
Copy link
Author

Thanks @justinh24 I'd be happy to finish it. I just didn't want to proceed if y'all didn't want to support it. I will get to this at some point. Expect to see a merge request in the coming days or months.

Cheers!

@justinh24
Copy link
Member

Sounds good.. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants