refund workaround #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 24, 2024 20:25
…lient and server, mm bot rework of basic strategy to make it competitive, relax requirements for POL reserved/locked for fees, get rid of depth chart, other UI cleanup
…llowed previuosly)
…r book orders to be complete
…s (not follow) rapid market price changes
…more frequently due to aggressive rate limiting)
… to fall back to other rate-sources occasionally
… source only since other sources have strict rate limits)
…unknown transaction
…te only as reference point)
* ui: markets page rework (mainly order-form) * fix rate conversion(s), get rid of swap options views (and rework showVerify), get rid of translations as unnecessary burden * fix decimal number inputs (getting rid of number in favor of text + additional js validation) * turn off selection history for order-forms * handle balance update notes properly * rework market list * minor visual adjustments (margins and such) * add reference fiat rate in orange * move order-forms under candle chart * fix scaling with browser zoom * fix total calculation for buy/sell forms * order-form: resolve some edge-cases around invalid inputs * refactor number parsing for rate/qty fields, allow for comma * rework active orders section to only show active/relevant orders * order-form: optimize buy/sell buttons * refactor out unnecessary delay param * rework slider to make it more vibrant, general order form improvements & bug fixes (element alignment and such) * markets: shrink header a bit, limit order book-side size to 14 so we don't have to scroll UI * improve rate/qty fields parsing * improve slider handling * markets: adding order to book-side should be smooth * markets: rework header, rework spot-price display * minor sell slider fix * minor markets-header adjustments * markets: misc adjustments (mostly header) * order-form default price should be best buy/sell (not mid-gap) * form-label should not affect cursor * rework market header (mostly to simplify code involved), format total in/out properly, make candle-chart scaling/zooming smooth (add more zoom-levels) * get rid of redundant trading limits info, remove what's left of wallet locking in UI, adjust markets header * fix number formatting all across UI * introduce a work-around for insanely high server-configured rate-step * refactor matches table code, swap column order for more clear signal, add asset symbols to clarify what Rate/Size are * refactor qty parsing (order-form) * refactor rate/coin formatting, format qty to lot size (in order-book, matches table) * reverse rate/qty columns in order-book to make qty easier to read * use precise to-lot formatting where it makes sense * rework order-book to highlight order relevance (based on quantity and price) * fix typo/bug with converting floating-point numbers to atomic numbers (which are always integers) * (when formatting decimals in UI) don't show comma since it's confusing when combined with decimal dot * candle chart refactoring/adjustments (mostly related to making scrolling smooth, adjusting paddings, and moving price labels to a separate column on the right); plus minor bug fixes unrelated to candle chart * candle-chart: make scrolling smoother * fix forms formatting * candle-chart: fixes & adjustments (proper life-cycle handling) * variuos adjustments to make things pretty * re-arrange stats on market header (mostly around bison/fiat price), fix the way candles/market is loaded * markets: remove order-acceleration functionality since it doesn't belong on this page (we can accelerate on order-view if necessary), add a bunch of missing await calls * add tooltips for bison/external prices, display external price on the order-book as well * use defined constant instead of hardcoded value (for colors), make MM overview view background distinct from created bot configurations * order-form: make use of change handler for price/qty inputs to address some quirks of current implementation * minor adjustments * handle edge-case related to user order still showing in UI but no longer being relevant (eg. order in submitting status) * adjust the way candlesLoaded notification gets handled in UI to make it fully symmetric * matches table - update Age column to be a timestamp in hh-mm-ss format (for simpler readability) and only show recent (24h in the past) matches; also rework order-book mid-section * use more compact date-time for display on candle chart (when candle is hovered) * rework market page UI colors, minor mics adjustments * update the way order-book looks, add % delta relative to external price * remove last match data from order-book to keep it clean and simple * order-book: periodically update price delta(s) * cut margins for date-time displayed on candle chart (when candle is hovered), adjust profit threshold * display negative price delta with opposite color to make it clearly visible in UI * refactor code around recent matches & open orders (called active orders previuosly); add completed orders views (and extend order filtering API to support the use-case of fetching trully relevant orders); format quantities on open/completed views to lot size; finally, minor adjustments to relevant html/css have been made * update OrderReader.StatusString func to correspond to what we have in JS * properly count/display total/locked wallet balances * fix incorrect fee displayed in UI for user-prompt action to bump fees (also display fiat rate alongside); improve the way stuck EVM transactions are handled so that fee-bumps actually work; respects user-configured MaxFee estimate for redeems --------- Co-authored-by: norwnd <norwnd>
…kets, bump HTTP response read limit to allow for fetching oracle rates (for certain markets the amount of data to fetch is just higher)
…ed history (these are shown in open orders section)
…acing immediately matching orders (as a safety precaution)
…t red/green colors on markets page, use Binance-like own order market (orange dot) since it's nice and clean compared to everything else I've tried
norwnd
force-pushed
the
master
branch
3 times, most recently
from
d48f396 to
0b78bfd
Compare
norwnd
force-pushed
the
master
branch
3 times, most recently
from
b985e49 to
faf1d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how a Refund can be "manually" issued for a match with specific match ID (all
TODOplaceholders need to be replaced with target match ID) in case it didn't happen automatically for whatever reason (eg. it's stuck due to low fees)