Sync with upstream #112
Sync with upstream #112
Conversation
![nips-ja-sync[bot]](https://avatars.githubusercontent.com/u/130643095?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
54.md
Outdated
| `e` tag: optional version of the article in which this modifications is based | ||
| `e` tag with `source` marker: the ID of the event that should be merged. This event id MUST be of a `kind:30818` as defined in this NIP. | ||
|
|
||
| The destination-pubkey (the pubkey being requested to merge something into their article can create [[NIP-25]] reactions that tag the `kind:818` event with `+` or `-` |
There was a problem hiding this comment.
🚫 [textlint] <eslint.rules.ja-technical-writing/no-unmatched-pair> reported by reviewdog 🐶
Not found pair character for (.
You should close this sentence with ).
This pair mark is called round bracket(). (ja-technical-writing/no-unmatched-pair)
nips-ja-sync
bot
force-pushed
the
sync
branch
2 times, most recently
from
163258e to
4799fba
Compare
relax requirements for NIP 32 L tags
README: remove `l` tag annotations
NIP-57: Clarify description tag
BREAKING.md: add changes
NIP-09: clarify "a" tag deletions
NIP-24: fix missing rename
Small grammatical change for easier reading
This is not a correction but a suggestion... When I first read it, it wasn't clear that metadata is specifically for a user and not inclusive of other things (eg not metadata about a photo). Adding this one extra word here would have helped me understand that immediately.
Changed Metadata to User's Metadata, to reduce ambiguity.
Changed metadata to user's metadata
* Update 01.md A few small changes that can potentially help a broader audience (non-developers) follow the meaning. * monospace hex Co-authored-by: Asai Toshiya <[email protected]> --------- Co-authored-by: fiatjaf_ <[email protected]> Co-authored-by: Asai Toshiya <[email protected]>
metadata clarity.md
NIP-28: simplify and fix kind 41
nips-ja-sync
bot
force-pushed
the
sync
branch
from
4833cdf to
784a948
Compare
|
どの差分を追ってるのかわからなくなりそう |
|
@s3-odara 指摘①、②: kind0の呼び名目次の説明ではメタデータになっていたので、metadata, user's metadata -> メタデータ にしてもよいかなと 指摘③json -> jsoncの単純な指摘 指摘④コンフリクトマーカーがついたまま |
|
ありがとうございます。 1,2については上流でmetadataからuser metadataへの変更があったので何らかの意図でuser matadataへ変更してるものだと解釈しました。 3も上流の変更です。 4についてはどこにコンフリクトマーカーが残っているかわかりますか？ |
|
指摘④のコンフリクトマーカーはここです。 |
|
コンフリクトマーカーは修正しました。 metadata, user's metadataについてはuser's metadataが本家に残ってるのがおそらくミスなので、本家の方でuser metadataに統一するPRを出したほうがいいかもしれないです。 |
"user matadata"
|
ああ、レビューコメント今見えました。 |
|
指摘③で言及したjson -> jsoncについては |
No description provided.