Sync with upstream #128
Merged
Sync with upstream #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nips-ja-sync[bot]](https://avatars.githubusercontent.com/u/130643095?s=60&v=4){kind=small}
Adds pronouns
NIP-47 notifications
s3-odara
approved these changes
Nov 25, 2024
darashi
reviewed
Nov 25, 2024
| @@ -6,7 +6,7 @@ NIP-24 | |||
|
|
|||
| `draft` `optional` | |||
|
|
|||
| このNIPはイベントに加えられる追加の任意のフィールドを定義する。 | |||
| このNIPはどこにも定義されていないが_事実上_標準になっているイベントに加えられる追加の任意のフィールドや、それ自体のNIPを作るに値せず、他のNIPにも受け入れられない些細な仕様を追跡する。 | |||
There was a problem hiding this comment.
LGTMですが、nitsとして、「は、」として主語の範囲を明示すると読みやすくなるかなと思いました。
Suggested change
| このNIPはどこにも定義されていないが_事実上_標準になっているイベントに加えられる追加の任意のフィールドや、それ自体のNIPを作るに値せず、他のNIPにも受け入れられない些細な仕様を追跡する。 | |
| このNIPは、どこにも定義されていないが_事実上_標準になっているイベントに加えられる追加の任意のフィールドや、それ自体のNIPを作るに値せず、他のNIPにも受け入れられない些細な仕様を追跡する。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.