Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 23.md #24

Merged
merged 17 commits into from
Dec 6, 2023
Merged

Update 23.md #24

merged 17 commits into from
Dec 6, 2023

Conversation

rira224
Copy link
Contributor

@rira224 rira224 commented Nov 14, 2023

I translated NIP-23. It is my first pull-requests, so if there are any mistakes I'm sorry.

I translated NIP-23. It is my first pull-requests, so if there are any mistakes I'm sorry.
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
23.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rira224 rira224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

誤字修正

@darashi
Copy link
Member

darashi commented Nov 14, 2023

#1 の「スタイルガイドなど」の項目に「ですます口調」と指定があります。

Copy link
Member

@erechorse erechorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不慣れな中翻訳ありがとうございます。

  • textlintの方の設定が不適切だったのでチェックが働いていないようですが、本文はですます口調で統一していただきたいです。
  • 基本的には英単語の両端など、文中に空白は差し込まなくてもいいと思います。ただ、 (このように) 括弧の両端には半角スペースを挿入したほうが良いかもしれません。
  • 原文9行目の翻訳で行数にずれが発生しているようです。対応する翻訳は同じ行に収めるようにお願いします。 参考

23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
rira224 and others added 4 commits November 14, 2023 19:12
Co-authored-by: 電子馬 <[email protected]>
Co-authored-by: 電子馬 <[email protected]>
Co-authored-by: 電子馬 <[email protected]>
・原文との段落を一致するよう修正
・文体をですます調に修正
23.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rira224 rira224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11行目の修正

23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
@erechorse erechorse mentioned this pull request Nov 16, 2023
23 tasks
Co-authored-by: Yoji Shidara <[email protected]>
@rira224
Copy link
Contributor Author

rira224 commented Nov 18, 2023

change.

rira224 and others added 4 commits November 19, 2023 02:42
Co-authored-by: Akiomi Kamakura <[email protected]>
Co-authored-by: Akiomi Kamakura <[email protected]>
Co-authored-by: Yoji Shidara <[email protected]>
23.md Outdated Show resolved Hide resolved
@s3-odara s3-odara mentioned this pull request Nov 20, 2023
7 tasks
Co-authored-by: Akiomi Kamakura <[email protected]>
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
23.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rira224 rira224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

@rira224 rira224 requested a review from erechorse December 5, 2023 12:08
23.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rira224 rira224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@erechorse erechorse merged commit d75d1c0 into nostr-jp:main Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants